Sudoku review #1

Open
BordedDev wants to merge 19 commits from BordedDev/sudoku:main into main
pull from: BordedDev/sudoku:main
merge into: retoor:main
Conversation 3 Commits 19 Files Changed 8 +1 -1
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit f08cd376a2 - Show all commits

2
reviews/BordedDev/sudoku.rewrite.js
View File

@ -95,7 +95,7 @@ class SudokuPuzzle extends EventTarget {
* @returns {undefined|number}
*/
#sampleRandomEmptyField(stateToSample = this.#activeState) {
const iters = [...stateToSample.entries().filter(([_, v]) => v == null)]
const iters = [...stateToSample.entries().filter(([, v]) => v == null)]
BordedDev commented 2025-01-17 00:05:39 +00:00
Outdated
Review
Copy Link

Recent learned that the variables are optional in destruction, had them as _ before.

Recent learned that the variables are optional in destruction, had them as `_` before.
if (iters.length > 0) {
return iters[randInt(0, iters.length - 1)][0]
}