From df9585322fbf46bef5cb230057162288e769bb23 Mon Sep 17 00:00:00 2001 From: Benjamin Claassen Date: Tue, 14 Jan 2025 23:14:14 +0100 Subject: [PATCH] Updated notes slightly --- reviews/BordedDev/notes.md | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/reviews/BordedDev/notes.md b/reviews/BordedDev/notes.md index 846954c..0f4d2de 100644 --- a/reviews/BordedDev/notes.md +++ b/reviews/BordedDev/notes.md @@ -2,13 +2,13 @@ It doesn’t render correctly on firefox but does in edge, it’s a rectangle, n Since the scaling is based on the font size, using `em` + `line-height: 1` allows it to scale correctly by adding it to `.sudoku-field`. Fixing it by wrapping the numbers and adding `height: 100%` fixes the individual cells, but the whole table is still a -rectangle but causes the cells to overlap. +rectangle but causes the cells to overlap (inside out size issues was excuse). There is a bunch of unused code Autosolver is broken, I had to move the function around -Switched .forEach to for loop for performance (recommended practice) +Switched .forEach to for loop for performance (recommended practice, but honestly it’s not a big deal) Convert the keyboard key lookup to a map, mostly stylistic but I imagine it’s also easier to edit. @@ -24,4 +24,7 @@ It's not recommended to setup the elements in the constructor https://developer. You can use `||=` for assigning to an undefined variable (if it's undefined) -Borders are on all grid elements, causing a double border on the edges \ No newline at end of file +Borders are on all grid elements, causing a double border on the edges + +I'd recommend running Biome.js or ESlint + Prettier to clean up the code +(if you're using ML you can even make these strict enough about ordering and naming conventions) \ No newline at end of file