From cfbd5a1ce4c9ddf90c58527a1c805bc1f78d4be7 Mon Sep 17 00:00:00 2001 From: retoor Date: Sat, 15 Feb 2025 12:23:46 +0000 Subject: [PATCH] fix: replace silent break with exception raise on ws close and error in RPC.receive Replace two silent `break` statements with explicit `Exception` raises when WebSocket closes or encounters an error, and remove a stray debug print statement. This ensures the caller is notified of connection failures instead of silently exiting the receive loop. --- src/snekbot/rpc.py | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/snekbot/rpc.py b/src/snekbot/rpc.py index f98cdac..a1f95b7 100644 --- a/src/snekbot/rpc.py +++ b/src/snekbot/rpc.py @@ -116,10 +116,9 @@ class RPC: print("Error while receiving:", ex) break if msg.type == aiohttp.WSMsgType.CLOSED: - break + raise Exception("WebSocket closed.") elif msg.type == aiohttp.WSMsgType.ERROR: - print("WebSocket error:", msg) - break + raise Exception("WebSocket error:", msg) elif msg.type == aiohttp.WSMsgType.TEXT: if self.current_call_id and not msg.json().get('callId') != self.current_call_id: @@ -134,5 +133,4 @@ class RPC: break else: raise Exception("Unexpected message type.") - print("huh") return None