From fe6bac5a08b8dfc8d91478f5ed78bd584ec9c147 Mon Sep 17 00:00:00 2001
From: Markus Heiser <markus.heiser@darmarit.de>
Date: Thu, 8 Aug 2024 11:46:54 +0200
Subject: [PATCH] [fix] pip install -e: legacy editable install (setup.py
develop) is deprecated
From [1]: There is now a standardized mechanism [2] for an installer like pip to
request an editable install of a project. pip is transitioning to using this
standard only instead of invoking the deprecated `setup.py develop` command.
For backward compatibility, we can use switches:
--use-pep517
https://pip.pypa.io/en/stable/cli/pip_install/#cmdoption-use-pep517
--no-build-isolation
https://pip.pypa.io/en/stable/cli/pip_install/#cmdoption-no-build-isolation
- [1] https://github.com/pypa/pip/issues/11457
- [2] https://peps.python.org/pep-0660/
Closes: https://github.com/searxng/searxng/issues/3701
Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
---
docs/build-templates/searxng.rst | 2 +-
docs/dev/makefile.rst | 4 ++--
manage | 4 ++--
utils/lib.sh | 4 ++--
utils/searxng.sh | 4 ++--
5 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/docs/build-templates/searxng.rst b/docs/build-templates/searxng.rst
index 14b385468..bc5d3e8fc 100644
--- a/docs/build-templates/searxng.rst
+++ b/docs/build-templates/searxng.rst
@@ -123,7 +123,7 @@ ${fedora_build}
# jump to SearXNG's working tree and install SearXNG into virtualenv
(${SERVICE_USER})$ cd \"$SEARXNG_SRC\"
- (${SERVICE_USER})$ pip install -e .
+ (${SERVICE_USER})$ pip install --use-pep517 --no-build-isolation -e .
.. END manage.sh update_packages
diff --git a/docs/dev/makefile.rst b/docs/dev/makefile.rst
index 3c3b2bf3b..383113bae 100644
--- a/docs/dev/makefile.rst
+++ b/docs/dev/makefile.rst
@@ -61,7 +61,7 @@ working tree and release a ``make install`` to get a virtualenv with a
$ make install
PYENV [virtualenv] installing ./requirements*.txt into local/py3
...
- PYENV [install] pip install -e 'searx[test]'
+ PYENV [install] pip install --use-pep517 --no-build-isolation -e 'searx[test]'
...
Successfully installed searxng-2023.7.19+a446dea1b
@@ -78,7 +78,7 @@ the check fails if you edit the requirements listed in
...
PYENV [virtualenv] installing ./requirements*.txt into local/py3
...
- PYENV [install] pip install -e 'searx[test]'
+ PYENV [install] pip install --use-pep517 --no-build-isolation -e 'searx[test]'
...
Successfully installed searxng-2023.7.19+a446dea1b
diff --git a/manage b/manage
index 2a88a4c5c..7edcb1f5a 100755
--- a/manage
+++ b/manage
@@ -299,8 +299,8 @@ pyenv.install() {
( set -e
pyenv
- build_msg PYENV "[install] pip install -e 'searx${PY_SETUP_EXTRAS}'"
- "${PY_ENV_BIN}/python" -m pip install -e ".${PY_SETUP_EXTRAS}"
+ build_msg PYENV "[install] pip install --use-pep517 --no-build-isolation -e 'searx${PY_SETUP_EXTRAS}'"
+ "${PY_ENV_BIN}/python" -m pip install --use-pep517 --no-build-isolation -e ".${PY_SETUP_EXTRAS}"
)
local exit_val=$?
if [ ! $exit_val -eq 0 ]; then
diff --git a/utils/lib.sh b/utils/lib.sh
index e527fa1b6..b932b875c 100755
--- a/utils/lib.sh
+++ b/utils/lib.sh
@@ -663,8 +663,8 @@ pyenv.install() {
pyenv
fi
for i in ${PYOBJECTS}; do
- build_msg PYENV "[install] pip install -e '$i${PY_SETUP_EXTRAS}'"
- "${PY_ENV_BIN}/python" -m pip install -e "$i${PY_SETUP_EXTRAS}"
+ build_msg PYENV "[install] pip install --use-pep517 --no-build-isolation -e '$i${PY_SETUP_EXTRAS}'"
+ "${PY_ENV_BIN}/python" -m pip install --use-pep517 --no-build-isolation -e "$i${PY_SETUP_EXTRAS}"
done
fi
pyenv.install.OK
diff --git a/utils/searxng.sh b/utils/searxng.sh
index ea6a467d2..c15c18218 100755
--- a/utils/searxng.sh
+++ b/utils/searxng.sh
@@ -501,7 +501,7 @@ pip install -U setuptools
pip install -U wheel
pip install -U pyyaml
cd ${SEARXNG_SRC}
-pip install -e .
+pip install --use-pep517 --no-build-isolation -e .
EOF
}
@@ -569,7 +569,7 @@ pip install -U pip
pip install -U setuptools
pip install -U wheel
pip install -U pyyaml
-pip install -U -e .
+pip install -U --use-pep517 --no-build-isolation -e .
EOF
rst_para "update instance's settings.yml from ${SEARXNG_SETTINGS_PATH}"
DEFAULT_SELECT=2 \