From 01ee3a6eddceeea2027d1489d550809ced65ab38 Mon Sep 17 00:00:00 2001 From: Adam Tauber Date: Wed, 24 Jun 2020 14:43:33 +0200 Subject: [PATCH 1/9] [fix] remove redundant alt texts from images in Videos, Social Media and Music results - #350 --- searx/templates/oscar/result_templates/default.html | 2 +- searx/templates/oscar/result_templates/videos.html | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/searx/templates/oscar/result_templates/default.html b/searx/templates/oscar/result_templates/default.html index 885cbbfa8..57365f34e 100644 --- a/searx/templates/oscar/result_templates/default.html +++ b/searx/templates/oscar/result_templates/default.html @@ -16,7 +16,7 @@ {%- if result.img_src -%}
-{{ result.title|striptags }} + {% if result.content %}

{{ result.content|safe }}

{% endif -%}
diff --git a/searx/templates/oscar/result_templates/videos.html b/searx/templates/oscar/result_templates/videos.html index 51ed5a025..6d9101d2e 100644 --- a/searx/templates/oscar/result_templates/videos.html +++ b/searx/templates/oscar/result_templates/videos.html @@ -15,7 +15,7 @@
- {{ result.title|striptags }} {{ result.engine }} + {% if result.author %}

{{ _('Author') }}: {{ result.author }}

{% endif %} {% if result.length %}

{{ _('Length') }}: {{ result.length }}

{% endif %} {% if result.content %}

{{ result.content|safe }}

{% endif %} From d418b593bb76b52f6ee4c52d27a1b557853cdd62 Mon Sep 17 00:00:00 2001 From: Adam Tauber Date: Wed, 24 Jun 2020 14:44:27 +0200 Subject: [PATCH 2/9] [fix] do not use h1 element for the logo --- searx/templates/oscar/index.html | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/searx/templates/oscar/index.html b/searx/templates/oscar/index.html index b941f5f20..48c49d64a 100644 --- a/searx/templates/oscar/index.html +++ b/searx/templates/oscar/index.html @@ -6,10 +6,10 @@ {% if cookies['oscar-style'] == 'pointhi' %}

searx logosearx

{% else %} -

+

+
{% endif %}
From 5ca52869123f40ad3cf991e78ad9baeaff52c4c2 Mon Sep 17 00:00:00 2001 From: Adam Tauber Date: Wed, 24 Jun 2020 15:00:33 +0200 Subject: [PATCH 3/9] [fix] indicate too high max time by e.g. icon not only by colour --- searx/templates/oscar/preferences.html | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/searx/templates/oscar/preferences.html b/searx/templates/oscar/preferences.html index 0d96ff5f2..cd4070d05 100644 --- a/searx/templates/oscar/preferences.html +++ b/searx/templates/oscar/preferences.html @@ -204,11 +204,11 @@ {{ support_toggle(stats[search_engine.name].supports_selected_language) }} {{ support_toggle(search_engine.safesearch==True) }} {{ support_toggle(search_engine.time_range_support==True) }} - {{ 'N/A' if stats[search_engine.name].time==None else stats[search_engine.name].time }} - {{ search_engine.timeout }} - {% else %} - {{ search_engine.timeout }} - {{ 'N/A' if stats[search_engine.name].time==None else stats[search_engine.name].time }} + {% if stats[search_engine.name]['warn_time'] %}{{ icon('exclamation-sign')}} {% endif %}{{ 'N/A' if stats[search_engine.name].time==None else stats[search_engine.name].time }} + {% if stats[search_engine.name]['warn_timeout'] %}{{ icon('exclamation-sign') }} {% endif %}{{ search_engine.timeout }} + {% else %} + {{ search_engine.timeout }}{% if stats[search_engine.name]['warn_time'] %} {{ icon('exclamation-sign')}}{% endif %} + {{ 'N/A' if stats[search_engine.name].time==None else stats[search_engine.name].time }}{% if stats[search_engine.name]['warn_time'] %} {{ icon('exclamation-sign')}}{% endif %} {{ support_toggle(search_engine.time_range_support==True) }} {{ support_toggle(search_engine.safesearch==True) }} {{ support_toggle(stats[search_engine.name].supports_selected_language) }} From fce2d496514f4ddfa725e9796c5b70e37a4dec74 Mon Sep 17 00:00:00 2001 From: Adam Tauber Date: Thu, 25 Jun 2020 15:51:42 +0200 Subject: [PATCH 4/9] [fix] use scope attribute to describe properties in the engine preferences table --- searx/templates/oscar/preferences.html | 36 +++++++++++++------------- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/searx/templates/oscar/preferences.html b/searx/templates/oscar/preferences.html index cd4070d05..3466df006 100644 --- a/searx/templates/oscar/preferences.html +++ b/searx/templates/oscar/preferences.html @@ -173,23 +173,23 @@ {% if not rtl %} - - - - - - - - + + + + + + + + {% else %} - - - - - - - - + + + + + + + + {% endif %} {% for search_engine in engines_by_category[categ] %} @@ -199,7 +199,7 @@ - + @@ -213,7 +213,7 @@ - + From 6ab569f5588e148bf73a7d80bc2f52bc737bf5e0 Mon Sep 17 00:00:00 2001 From: Adam Tauber Date: Thu, 25 Jun 2020 17:32:05 +0200 Subject: [PATCH 5/9] [fix] connect selects and inputs programmatically on the preferences page - #350 --- searx/templates/oscar/macros.html | 6 ++-- searx/templates/oscar/preferences.html | 48 +++++++++++++------------- 2 files changed, 27 insertions(+), 27 deletions(-) diff --git a/searx/templates/oscar/macros.html b/searx/templates/oscar/macros.html index c4b2a7ddb..809c9f595 100644 --- a/searx/templates/oscar/macros.html +++ b/searx/templates/oscar/macros.html @@ -60,15 +60,15 @@ {%- endif %} {%- endmacro %} -{% macro preferences_item_header(info, label, rtl) -%} +{% macro preferences_item_header(info, label, rtl, id) -%} {% if rtl %}
- + {{ info }}
{% else %}
- +
{% endif %} {%- endmacro %} diff --git a/searx/templates/oscar/preferences.html b/searx/templates/oscar/preferences.html index 3466df006..8d37b8be2 100644 --- a/searx/templates/oscar/preferences.html +++ b/searx/templates/oscar/preferences.html @@ -30,9 +30,9 @@
{% include 'oscar/categories.html' %}
- + {% else %} - +
{% include 'oscar/categories.html' %}
@@ -40,14 +40,14 @@
{% set language_label = _('Search language') %} {% set language_info = _('What language do you prefer for search?') %} - {{ preferences_item_header(language_info, language_label, rtl) }} + {{ preferences_item_header(language_info, language_label, rtl, 'language') }} {% include 'oscar/languages.html' %} {{ preferences_item_footer(language_info, language_label, rtl) }} {% set locale_label = _('Interface language') %} {% set locale_info = _('Change the language of the layout') %} - {{ preferences_item_header(locale_info, locale_label, rtl) }} - {% for locale_id,locale_name in locales.items() | sort %} {% endfor %} @@ -56,8 +56,8 @@ {% set autocomplete_label = _('Autocomplete') %} {% set autocomplete_info = _('Find stuff as you type') %} - {{ preferences_item_header(autocomplete_info, autocomplete_label, rtl) }} - {% for backend in autocomplete_backends %} @@ -67,8 +67,8 @@ {% set image_proxy_label = _('Image proxy') %} {% set image_proxy_info = _('Proxying image results through searx') %} - {{ preferences_item_header(image_proxy_info, image_proxy_label, rtl) }} - @@ -76,8 +76,8 @@ {% set method_label = _('Method') %} {% set method_info = _('Change how forms are submited, learn more about request methods') %} - {{ preferences_item_header(method_info, method_label, rtl) }} - @@ -85,8 +85,8 @@ {% set safesearch_label = _('SafeSearch') %} {% set safesearch_info = _('Filter content') %} - {{ preferences_item_header(safesearch_info, safesearch_label, rtl) }} - @@ -95,16 +95,16 @@ {% set theme_label = _('Themes') %} {% set theme_info = _('Change searx layout') %} - {{ preferences_item_header(theme_info, theme_label, rtl) }} - {% for name in themes %} {% endfor %} {{ preferences_item_footer(theme_info, theme_label, rtl) }} - {{ preferences_item_header(_('Choose style for this theme'), _('Style'), rtl) }} - @@ -113,8 +113,8 @@ {% set label = _('Results on new tabs') %} {% set info = _('Open result links on new browser tabs') %} - {{ preferences_item_header(info, label, rtl) }} - @@ -122,8 +122,8 @@ {% set label = _('Open Access DOI resolver') %} {% set info = _('Redirect to open-access versions of publications when available (plugin required)') %} - {{ preferences_item_header(info, label, rtl) }} - {% for doi_resolver_name,doi_resolver_url in doi_resolvers.items() %}
@@ -241,7 +241,7 @@

{{ _(plugin.name) }}

-
{{ _(plugin.description) }}
+
{{ checkbox_toggle('plugin_' + plugin.id, plugin.id not in allowed_plugins) }} From ec48447361045bf1e68d3634fcae862e77f85d92 Mon Sep 17 00:00:00 2001 From: Adam Tauber Date: Thu, 25 Jun 2020 17:43:37 +0200 Subject: [PATCH 6/9] [fix] change lang attribute of the html to match the current locale - #350 --- searx/templates/oscar/base.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/searx/templates/oscar/base.html b/searx/templates/oscar/base.html index 839619976..2ccadd700 100644 --- a/searx/templates/oscar/base.html +++ b/searx/templates/oscar/base.html @@ -1,6 +1,6 @@ {% from 'oscar/macros.html' import icon %} - + From cc164abdfcecef82eada0d4657475e4e55b65be8 Mon Sep 17 00:00:00 2001 From: Adam Tauber Date: Thu, 25 Jun 2020 18:12:28 +0200 Subject: [PATCH 7/9] [fix] make "Advanced settings" openable and usable with keyboard - #350 --- .../themes/oscar/css/logicodev-dark.css | 4 ++-- .../themes/oscar/css/logicodev-dark.min.css | Bin 13864 -> 13889 bytes searx/static/themes/oscar/css/logicodev.css | 4 ++-- .../static/themes/oscar/css/logicodev.min.css | Bin 10424 -> 10449 bytes .../themes/oscar/less/logicodev/advanced.less | 4 ++-- searx/templates/oscar/advanced.html | 2 +- 6 files changed, 7 insertions(+), 7 deletions(-) diff --git a/searx/static/themes/oscar/css/logicodev-dark.css b/searx/static/themes/oscar/css/logicodev-dark.css index 38b9dbaa9..cf32e76b9 100644 --- a/searx/static/themes/oscar/css/logicodev-dark.css +++ b/searx/static/themes/oscar/css/logicodev-dark.css @@ -435,8 +435,8 @@ Ny0yNFQxMToxNTowMCswMjowMP7RDgQAAAAZdEVYdFNvZnR3YXJlAHd3dy5pbmtzY2FwZS5vcmeb font-weight: bold; border-bottom: #01d7d4 5px solid; } -#check-advanced { - display: none; +#check-advanced:focus + label { + text-decoration: underline; } #check-advanced:checked ~ #advanced-search-container { display: block; diff --git a/searx/static/themes/oscar/css/logicodev-dark.min.css b/searx/static/themes/oscar/css/logicodev-dark.min.css index 6c7cf749a01ee88e35c7003fe2c28cacf896ccd6..b1eeba8a2baa5bf0d23600525562355187c80edd 100644 GIT binary patch delta 49 zcmZ3Hb1-MaENK<1wEX1KV(py7q|}`1lGKV4-IUbi{G!B?%=|p7(!7+^qMXdlOQoBo E00GeyA^-pY delta 24 fcmX?@vm$51ENSlQl+5CSoWx42y!_4kq?@GxiDL?5 diff --git a/searx/static/themes/oscar/css/logicodev.css b/searx/static/themes/oscar/css/logicodev.css index ad6d967b8..76af58357 100644 --- a/searx/static/themes/oscar/css/logicodev.css +++ b/searx/static/themes/oscar/css/logicodev.css @@ -408,8 +408,8 @@ Ny0yNFQxMToxNTowMCswMjowMP7RDgQAAAAZdEVYdFNvZnR3YXJlAHd3dy5pbmtzY2FwZS5vcmeb font-weight: bold; border-bottom: #01d7d4 5px solid; } -#check-advanced { - display: none; +#check-advanced:focus + label { + text-decoration: underline; } #check-advanced:checked ~ #advanced-search-container { display: block; diff --git a/searx/static/themes/oscar/css/logicodev.min.css b/searx/static/themes/oscar/css/logicodev.min.css index a39cc36b927c6f7ccc11ecc2b00844f15b1460c3..88b9dae54b152fd9a0868b984a2b588cd1162b93 100644 GIT binary patch delta 49 zcmdlHcrkDTyR3>;T7GhAv35>kQff|hNoqxjZc1u$eo +
{{ _("Allow") }}{{ _("Engine name") }}{{ _("Shortcut") }}{{ _("Selected language") }}{{ _("SafeSearch") }}{{ _("Time range") }}{{ _("Avg. time") }}{{ _("Max time") }}{{ _("Allow") }}{{ _("Engine name") }}{{ _("Shortcut") }}{{ _("Selected language") }}{{ _("SafeSearch") }}{{ _("Time range") }}{{ _("Avg. time") }}{{ _("Max time") }}{{ _("Max time") }}{{ _("Avg. time") }}{{ _("Time range") }}{{ _("SafeSearch") }}{{ _("Selected language") }}{{ _("Shortcut") }}{{ _("Engine name") }}{{ _("Allow") }}{{ _("Max time") }}{{ _("Avg. time") }}{{ _("Time range") }}{{ _("SafeSearch") }}{{ _("Selected language") }}{{ _("Shortcut") }}{{ _("Engine name") }}{{ _("Allow") }}
{{ checkbox_toggle('engine_' + search_engine.name|replace(' ', '_') + '__' + categ|replace(' ', '_'), (search_engine.name, categ) in disabled_engines) }} {{ search_engine.name }}{{ search_engine.name }} {{ shortcuts[search_engine.name] }} {{ support_toggle(stats[search_engine.name].supports_selected_language) }} {{ support_toggle(search_engine.safesearch==True) }}{{ support_toggle(search_engine.safesearch==True) }} {{ support_toggle(stats[search_engine.name].supports_selected_language) }} {{ shortcuts[search_engine.name] }}{{ search_engine.name }}{{ search_engine.name }} {{ checkbox_toggle('engine_' + search_engine.name|replace(' ', '_') + '__' + categ|replace(' ', '_'), (search_engine.name, categ) in disabled_engines) }}