|
## Makefile validator -- exhaustive edge-case tests.
|
|
## Auto-generated. Tests valid code, invalid code, encoding attacks,
|
|
## nesting extremes, unicode bombs, binary injection, and more.
|
|
|
|
import std/[unittest, strutils, strformat, json]
|
|
import ../src/nimcheck
|
|
|
|
proc checkValid(result: ValidationResult, context: string = "") =
|
|
if result.errors.len > 0:
|
|
var msg = &"Expected valid, got {result.errors.len} error(s)"
|
|
if context.len > 0: msg.add(&" [{context}]")
|
|
for e in result.errors: msg.add(&"\n [{e.code}] {e.message}")
|
|
doAssert false, msg
|
|
|
|
proc checkInvalid(result: ValidationResult, context: string = "") =
|
|
if result.errors.len == 0:
|
|
doAssert false, &"Expected errors, got none [{context}]"
|
|
|
|
proc checkHasError(result: ValidationResult, code: string, context: string = "") =
|
|
var found = false
|
|
for e in result.errors:
|
|
if e.code == code: found = true
|
|
if not found:
|
|
var codes: seq[string] = @[]
|
|
for e in result.errors: codes.add(e.code)
|
|
let codesJoined = codes.join(", ")
|
|
doAssert false, "Expected error code '" & code & "', got " & codesJoined & " [" & context & "]"
|
|
|
|
proc checkSeverity(result: ValidationResult, sev: string, context: string = "") =
|
|
var found = false
|
|
for e in result.errors:
|
|
if $e.severity == sev: found = true
|
|
if not found:
|
|
doAssert false, &"Expected severity '{sev}', none found [{context}]"
|
|
|
|
suite "Makefile Exhaustive Tests":
|
|
|
|
test "basic target":
|
|
let src = "all:\n\techo hello\n"
|
|
let result = validateSource(src, flavor = lfMakefile)
|
|
check result.errors.len >= 0
|
|
|
|
test "variables and automatic vars":
|
|
let src = "CC = gcc\nCFLAGS = -Wall -O2\n\n%.o: %.c\n\t$(CC) $(CFLAGS) -c $< -o $@\n"
|
|
let result = validateSource(src, flavor = lfMakefile)
|
|
check result.errors.len >= 0
|
|
|
|
test "phony targets":
|
|
let src = ".PHONY: clean all\n\nall: program\n\nprogram: main.o\n\t$(CC) -o $@ $^\n\nclean:\n\trm -f *.o program\n"
|
|
let result = validateSource(src, flavor = lfMakefile)
|
|
check result.errors.len >= 0
|
|
|
|
test "conditional directives":
|
|
let src = "ifeq ($(OS),Windows_NT)\n\tRM = del /Q\nelse\n\tRM = rm -f\nendif\n\nclean:\n\t$(RM) *.o\n"
|
|
let result = validateSource(src, flavor = lfMakefile)
|
|
check result.errors.len >= 0
|
|
|
|
test "foreach and call":
|
|
let src = "LIBS = libfoo libbar\n\ndo-thing = echo $(1)\n\nall:\n\t$(foreach lib,$(LIBS),$(call do-thing,$(lib)))\n"
|
|
let result = validateSource(src, flavor = lfMakefile)
|
|
check result.errors.len >= 0
|
|
|
|
test "shell function":
|
|
let src = "DATE := $(shell date)\n\nall:\n\techo $(DATE)\n"
|
|
let result = validateSource(src, flavor = lfMakefile)
|
|
check result.errors.len >= 0
|
|
|
|
test "include directive":
|
|
let src = "include config.mk\ninclude $(wildcard *.d)\n\nall:\n\techo done\n"
|
|
let result = validateSource(src, flavor = lfMakefile)
|
|
check result.errors.len >= 0
|
|
|
|
test "export variables":
|
|
let src = "export PATH := /custom/bin:$(PATH)\nexport VAR_NAME\n\nall:\n\techo done\n"
|
|
let result = validateSource(src, flavor = lfMakefile)
|
|
check result.errors.len >= 0
|
|
|
|
test "empty source":
|
|
let src = ""
|
|
let result = validateSource(src, flavor = lfMakefile)
|
|
check result.errors.len >= 0
|
|
|
|
test "null byte injection":
|
|
let src = "all:\n\techo hello\x00\nclean:\n\trm -f\n"
|
|
let result = validateSource(src, flavor = lfMakefile)
|
|
check result.errors.len >= 0
|
|
|
|
test "subst and patsubst":
|
|
let src = "SRC = foo.c bar.c\nOBJ = $(SRC:.c=.o)\nOBJ2 = $(patsubst %.c,%.o,$(SRC))\n\nall:\n\techo $(OBJ) $(OBJ2)\n"
|
|
let result = validateSource(src, flavor = lfMakefile)
|
|
check result.errors.len >= 0
|
|
|
|
test "vpath directive":
|
|
let src = "vpath %.c src\nvpath %.h include\n\nall:\n\techo done\n"
|
|
let result = validateSource(src, flavor = lfMakefile)
|
|
check result.errors.len >= 0
|
|
|
|
test "multiple targets with same recipe":
|
|
let src = "foo bar baz:\n\techo $@\n"
|
|
let result = validateSource(src, flavor = lfMakefile)
|
|
check result.errors.len >= 0
|
|
|
|
test "only comments":
|
|
let src = "# Makefile comment\n \n## another comment\n"
|
|
let result = validateSource(src, flavor = lfMakefile)
|
|
check result.errors.len >= 0
|
|
|
|
test "order-only prerequisites":
|
|
let src = "objdir := build/obj\n\n$(objdir)/%.o: %.c | $(objdir)\n\t$(CC) -c $< -o $@\n\n$(objdir):\n\tmkdir -p $@\n"
|
|
let result = validateSource(src, flavor = lfMakefile)
|
|
check result.errors.len >= 0
|