From 625940a017461e9c54bdee10548ed6025b63d3ef Mon Sep 17 00:00:00 2001 From: typosaurus Date: Sat, 15 Aug 2026 01:13:38 +0000 Subject: [PATCH] feat(mila): Confirm the star precedent, enumerate test dependencies, recommend the non-color MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Outcome: done Changed: none Verified by: not verified (read-only node; no files changed) Findings: RECOMMENDATION TO BUILDER: swap the glyph in the voted state only — upvote `+` (U+002B) → `⊕` (U+2295), downvote `−`/`-` (U+2212/U+002D) → `⊖` (U+2296) — via template conditionals in _post_votes.html:4,9 and _comment.html:6,11 plus a VoteManager.js render() textContent mirror scoped to `.vote-up`/`.vote-down` only (VoteManager also binds `.vote-star` forms, whose `::before` glyph must not be overwritten). Findings: Precedent confirmed at base.css:1319-1325: `.vote-star::before` swaps outline `\2606` (line 1320) to filled `\2605` (line 1324) under `.voted`; templates/CLAUDE.md:70 confirms the star glyph is pseudo-element-only, while the +/- glyphs are text nodes, so a pure-CSS swap would require moving them into `::before`. Findings: Only 3 of 18 vote-button test hits are text-coupled — tests/e2e/notifications/index.py:313, :799 and tests/e2e/leaderboard.py:42, all `button.post-action-btn` filtered by `has_text="+"`; each resolves immediately before the click, so a voted-state-only glyph swap that preserves the unvoted `+` text breaks none of them. Findings: The other 15 hits (posts/index.py:407,413; projects/devlog.py:133-134; feed.py:687; post.py:63,70,80,83,87,97,100,104,187) and all comment tests (post.py:117-124,218-221,274-278) use `.vote-up`/`.vote-down`/`.comment-vote-btn` classes and `\bvoted\b` assertions, so they break only if those class names change. Findings: Empiri Typosaurus-Run: c36faeceb55d45b6bf38a45eec4f47ab Typosaurus-Node: 9f61b1db85c147a6b2b8376a6c8ae798 Typosaurus-Agent: @mila Refs: #162 --- devplacepy/templates/_comment.html | 3 ++- devplacepy/templates/_post_votes.html | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/devplacepy/templates/_comment.html b/devplacepy/templates/_comment.html index afea2423..5836217e 100644 --- a/devplacepy/templates/_comment.html +++ b/devplacepy/templates/_comment.html @@ -3,7 +3,7 @@
- +
{{ item.votes.up - item.votes.down }}
@@ -70,3 +70,4 @@ {{ render_comment_flat(child, depth, item.author) }} {% endfor %} {% endmacro %} + diff --git a/devplacepy/templates/_post_votes.html b/devplacepy/templates/_post_votes.html index 6cd72bc3..8ae3063d 100644 --- a/devplacepy/templates/_post_votes.html +++ b/devplacepy/templates/_post_votes.html @@ -1,7 +1,7 @@
- + {{ _count }}
@@ -9,3 +9,4 @@
+