devplacepy/tests/api/messages/index.py

# retoor <retoor@molodetz.nl>

import time
from datetime import datetime, timezone
import pytest
import requests
from tests.conftest import BASE_URL
from devplacepy.database import get_table, refresh_snapshot, set_setting
from devplacepy.utils import generate_uid, make_combined_slug
JSON_audit_log = {"Accept": "application/json"}
_counter_audit_log = [0]
@pytest.fixture(scope="module", autouse=True)
def _audit_test_settings(app_server):
    # On a fresh DB init_db skips seeding the operational/upload settings (its
    # `tables` snapshot predates site_settings creation), so those rows are
    # absent and the admin settings form would INSERT them as "" - which both
    # closes registration and makes consumers that do int("") crash. Seed sane
    # values here so the form's empty submissions are skipped (existing key), and
    # lift the per-IP rate limit since this file fires many mutating requests.
    for key, value in {
        "rate_limit_per_minute": "1000000",
        "rate_limit_window_seconds": "60",
        "registration_open": "1",
        "maintenance_mode": "0",
        "max_upload_size_mb": "10",
        "allowed_file_types": "",
        "max_attachments_per_resource": "10",
        "session_max_age_days": "7",
        "session_remember_days": "30",
        "news_service_interval": "3600",
        "news_grade_threshold": "7",
    }.items():
        set_setting(key, value)
    yield
def _db_user(name):
    # the user is created by the server subprocess; refresh the test-process
    # SQLite snapshot before reading it back across the process boundary.
    refresh_snapshot()
    return get_table("users").find_one(username=name)
def _unique(prefix="au"):
    _counter_audit_log[0] += 1
    return f"{prefix}{int(time.time() * 1000)}{_counter_audit_log[0]}"
def _member():
    name = _unique("aumem")
    s = requests.Session()
    s.post(
        f"{BASE_URL}/auth/signup",
        data={
            "username": name,
            "email": f"{name}@t.dev",
            "password": "secret123",
            "confirm_password": "secret123",
        },
        allow_redirects=True,
    )
    return s, name
def _member_key():
    _, name = _member()
    return _db_user(name)["api_key"]
def _admin(seeded_db):
    # authenticate via the seeded admin's API key (header auth) rather than a
    # login POST - GET reads are exempt from the rate limiter, so reusing this
    # across the file's many tests never counts against the per-IP write budget.
    key = _db_user("alice_test")["api_key"]
    s = requests.Session()
    s.headers.update({"X-API-KEY": key})
    return s
def _audit(admin, **params):
    r = admin.get(f"{BASE_URL}/admin/audit-log", headers=JSON_audit_log, params=params)
    assert r.status_code == 200, r.text[:300]
    return r.json()
def _find(admin, event_key, predicate):
    data = _audit(admin, event_key=event_key)
    for entry in data["entries"]:
        if predicate(entry):
            return entry
    return None
def _new_post(session, body="audited post body here"):
    return session.post(
        f"{BASE_URL}/posts/create",
        headers=JSON_audit_log,
        data={"title": _unique("aup"), "content": body, "topic": "devlog"},
    ).json()["data"]
def _new_project(session):
    return session.post(
        f"{BASE_URL}/projects/create",
        headers=JSON_audit_log,
        data={
            "title": _unique("aupr"),
            "description": "audited project description text",
            "project_type": "software",
            "status": "In Development",
            "platforms": "",
        },
    ).json()["data"]
def _seed_news_audit_log():
    uid = generate_uid()
    title = _unique("aunews")
    get_table("news").insert(
        {
            "deleted_at": None,
            "deleted_by": None,
            "uid": uid,
            "slug": make_combined_slug(title, uid),
            "title": title,
            "external_id": uid,
            "status": "draft",
            "featured": 0,
            "show_on_landing": 0,
            "grade": 5,
            "source_name": "AuditTest",
            "synced_at": datetime.now(timezone.utc).isoformat(),
            "description": "audited news article",
        }
    )
    refresh_snapshot()
    return uid
JSON_content_negotiation = {"Accept": "application/json"}
_counter_content_negotiation = [0]
def _session_content_negotiation(password="secret123"):
    _counter_content_negotiation[0] += 1
    name = f"cn{int(time.time() * 1000)}{_counter_content_negotiation[0]}"
    s = requests.Session()
    s.post(
        f"{BASE_URL}/auth/signup",
        data={
            "username": name,
            "email": f"{name}@t.dev",
            "password": password,
            "confirm_password": password,
        },
        allow_redirects=True,
    )
    return s, name
PUBLIC_PAGES = ["/feed", "/projects", "/gists", "/news", "/leaderboard", "/issues"]


def test_security_authz_denied_recorded(seeded_db):
    requests.get(f"{BASE_URL}/messages", allow_redirects=False)
    admin = _admin(seeded_db)
    event = _find(
        admin,
        "security.authz.denied",
        lambda e: e.get("request_path") == "/messages",
    )
    assert event is not None
    assert event["result"] == "denied"


def test_unauthenticated_json_request_is_401_not_redirect(app_server):
    r = requests.get(f"{BASE_URL}/messages", headers=JSON_content_negotiation, allow_redirects=False)
    assert r.status_code == 401
    # browser guest still redirects to login
    rh = requests.get(f"{BASE_URL}/messages", allow_redirects=False)
    assert rh.status_code == 303


def test_messages_conversation_renders_presence_indicator(app_server):
    sender, _ = _member()
    _, other_name = _member()
    other_uid = _db_user(other_name)["uid"]
    r = sender.get(f"{BASE_URL}/messages?with_uid={other_uid}")
    assert r.status_code == 200
    assert "messages-presence" in r.text
    assert f'data-presence-uid="{other_uid}"' in r.text


def test_messages_conversation_list_avatar_has_presence_dot(app_server):
    sender, _ = _member()
    _, other_name = _member()
    other_uid = _db_user(other_name)["uid"]
    sent = sender.post(
        f"{BASE_URL}/messages/send",
        data={"receiver_uid": other_uid, "content": "hi there"},
        allow_redirects=True,
    )
    assert sent.status_code == 200, sent.text[:300]
    html = sender.get(f"{BASE_URL}/messages").text
    assert "conversation-item" in html
    assert "presence-dot" in html
    assert f'data-presence-uid="{other_uid}"' in html


def test_notification_open_does_not_mark_messages_read(app_server, seeded_db):
    """Regression: opening a DM notification must NOT mark the conversation read.
    The GET /messages?with_uid=... handler should NOT call mark_conversation_read;
    only the WebSocket markRead mechanism should do that.
    """
    sender, sender_name = _member()
    receiver, receiver_name = _member()

    refresh_snapshot()
    sender_user = _db_user(sender_name)
    receiver_user = _db_user(receiver_name)

    send_resp = sender.post(
        f"{BASE_URL}/messages/send",
        data={"receiver_uid": receiver_user["uid"], "content": "DM that must stay unread"},
        allow_redirects=True,
    )
    assert send_resp.status_code == 200, send_resp.text[:300]

    refresh_snapshot()
    msg = get_table("messages").find_one(
        sender_uid=sender_user["uid"], receiver_uid=receiver_user["uid"]
    )
    assert msg is not None, "message should exist"
    assert msg["read"] == 0, f"expected read=0 after send, got {msg['read']}"

    n_uid = generate_uid()
    get_table("notifications").insert({
        "uid": n_uid,
        "user_uid": receiver_user["uid"],
        "type": "message",
        "message": "sent you a message",
        "related_uid": sender_user["uid"],
        "target_url": f"/messages?with_uid={sender_user['uid']}",
        "read": False,
        "created_at": datetime.now(timezone.utc).isoformat(),
    })

    receiver.get(f"{BASE_URL}/notifications/open/{n_uid}", allow_redirects=True)

    refresh_snapshot()
    n = get_table("notifications").find_one(uid=n_uid)
    assert n is not None, "notification should exist"
    assert n["read"] in (1, True, "1"), "notification should be marked read"

    refresh_snapshot()
    msg_after = get_table("messages").find_one(uid=msg["uid"])
    assert msg_after is not None, "message should still exist"
    assert msg_after["read"] == 0, (
        f"expected read=0 after notification open, got {msg_after['read']}"
    )