Reduce default String length of pk to 255

Browse Source
This commit is contained in:
Stefan Wehrmeyer 2014-01-31 21:11:12 +01:00
parent a34315818f
commit ed007bf4be
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
dataset/persistence/database.py
View File

@ -121,7 +121,7 @@ class Database(object):
as the primary key of the table. Automatic id is set to be an as the primary key of the table. Automatic id is set to be an
auto-incrementing integer, while the type of custom primary_id can be a auto-incrementing integer, while the type of custom primary_id can be a
String or an Integer as specified with primary_type flag. The default String or an Integer as specified with primary_type flag. The default
length of String is 256. The caller can specify the length. length of String is 255. The caller can specify the length.
The caller will be responsible for the uniqueness of manual primary_id. The caller will be responsible for the uniqueness of manual primary_id.
This custom id feature is only available via direct create_table call. This custom id feature is only available via direct create_table call.
@ -148,10 +148,10 @@ class Database(object):
auto_flag = True auto_flag = True
col = Column(primary_id, Integer, primary_key=True, autoincrement=auto_flag) col = Column(primary_id, Integer, primary_key=True, autoincrement=auto_flag)
elif not match.group(3): elif not match.group(3):
col = Column(primary_id, String(256), primary_key=True) col = Column(primary_id, String(255), primary_key=True)
else: else:
len_string = int(match.group(3)[1:-1]) len_string = int(match.group(3)[1:-1])
len_string = min(len_string, 256) len_string = min(len_string, 255)
col = Column(primary_id, String(len_string), primary_key=True) col = Column(primary_id, String(len_string), primary_key=True)
else: else:
raise DatasetException( raise DatasetException(