Fix Devii open-trigger race and close two flaky e2e waits

DeviiTerminal bound [data-devii-open] click listeners only after the
async /devii/session fetch resolved, silently dropping early clicks.
Switch to a single delegated document listener bound in the
constructor, matching the ModalManager/dp-lightbox pattern.

The steal-confirm and comment-vote e2e tests asserted DOM state right
after a click with no wait for the triggering POST to land, racing the
server under CI load. Wrap those clicks in page.expect_response.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
retoor 2026-08-16 02:02:34 +02:00
parent fa8751a4ca
commit 8db0efff29
3 changed files with 19 additions and 10 deletions

View File

@ -10,6 +10,7 @@ export class DeviiTerminal {
this.avatar = null;
this.bindEscapeTrigger();
this.bindDoubleClickTrigger();
this.bindOpenTrigger();
this.ready = this.init();
}
@ -29,16 +30,19 @@ export class DeviiTerminal {
this.element.setAttribute("avatar", "devii");
document.body.appendChild(this.element);
this.bindTriggers();
this.maybeAutoOpen();
}
bindTriggers() {
document.querySelectorAll("[data-devii-open]").forEach((trigger) => {
trigger.addEventListener("click", (event) => {
event.preventDefault();
this.open(trigger.dataset.deviiPrompt || "");
});
bindOpenTrigger() {
document.addEventListener("click", (event) => {
const trigger = event.target.closest("[data-devii-open]");
if (!trigger) return;
event.preventDefault();
this.open(trigger.dataset.deviiPrompt || "");
});
}
maybeAutoOpen() {
const stored = this.element && this.element.hasStoredState && this.element.hasStoredState();
if (document.querySelector("[data-devii-autoopen]") && !stored) {
this.open();

View File

@ -128,7 +128,8 @@ def test_steal_takes_build_and_pays_thief(bob):
steal.click()
confirm_btn = page.locator(".dialog-confirm")
confirm_btn.wait_for(state="visible")
confirm_btn.click()
with page.expect_response(lambda r: "/steal" in r.url and r.request.method == "POST"):
confirm_btn.click()
expect(page.locator("form[data-game-action='steal']")).to_have_count(0)
page.wait_for_timeout(400)
assert _farm_coins("bob_test") == 18
@ -165,7 +166,8 @@ def test_victim_notification_names_the_raider_and_the_amount(bob):
steal.click()
confirm_btn = page.locator(".dialog-confirm")
confirm_btn.wait_for(state="visible")
confirm_btn.click()
with page.expect_response(lambda r: "/steal" in r.url and r.request.method == "POST"):
confirm_btn.click()
expect(page.locator("form[data-game-action='steal']")).to_have_count(0)
page.wait_for_timeout(400)
note = get_table("notifications").find_one(

View File

@ -114,7 +114,10 @@ def test_comment_voted_state_persists(alice):
expect(
page.locator(".comment-text:has-text('Comment whose vote should persist')")
).to_be_visible()
page.locator(".comment-vote-btn").first.click()
with page.expect_response(
lambda r: "/votes/" in r.url and r.request.method == "POST"
):
page.locator(".comment-vote-btn").first.click()
expect(page.locator(".comment-vote-btn").first).to_have_class(
re.compile(r"\bvoted\b")
)