Updated notes slightly

Browse Source
This commit is contained in:
BordedDev 2025-01-14 23:14:14 +01:00
parent ce5dead2cb
commit ec3b55b2f3
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
reviews/BordedDev/notes.md
View File

@ -2,13 +2,13 @@ It doesn’t render correctly on firefox but does in edge, it’s a rectangle, n
Since the scaling is based on the font size, using `em` + `line-height: 1` allows it to scale correctly by adding it to Since the scaling is based on the font size, using `em` + `line-height: 1` allows it to scale correctly by adding it to
`.sudoku-field`. `.sudoku-field`.
Fixing it by wrapping the numbers and adding `height: 100%` fixes the individual cells, but the whole table is still a Fixing it by wrapping the numbers and adding `height: 100%` fixes the individual cells, but the whole table is still a
rectangle but causes the cells to overlap. rectangle but causes the cells to overlap (inside out size issues was excuse).
There is a bunch of unused code There is a bunch of unused code
Autosolver is broken, I had to move the function around Autosolver is broken, I had to move the function around
Switched .forEach to for loop for performance (recommended practice) Switched .forEach to for loop for performance (recommended practice, but honestly it’s not a big deal)
Convert the keyboard key lookup to a map, mostly stylistic but I imagine it’s also easier to edit. Convert the keyboard key lookup to a map, mostly stylistic but I imagine it’s also easier to edit.
@ -24,4 +24,7 @@ It's not recommended to setup the elements in the constructor https://developer.
You can use `||=` for assigning to an undefined variable (if it's undefined) You can use `||=` for assigning to an undefined variable (if it's undefined)
Borders are on all grid elements, causing a double border on the edges Borders are on all grid elements, causing a double border on the edges
I'd recommend running Biome.js or ESlint + Prettier to clean up the code
(if you're using ML you can even make these strict enough about ordering and naming conventions)